Skip to content

Hono server / SEO + improvements#5

Merged
AlemTuzlak merged 7 commits intomainfrom
hono-server
Oct 10, 2024
Merged

Hono server / SEO + improvements#5
AlemTuzlak merged 7 commits intomainfrom
hono-server

Conversation

@AlemTuzlak
Copy link
Copy Markdown
Contributor

@AlemTuzlak AlemTuzlak commented Oct 8, 2024

Description

Added:

  • hono server with i18next
  • .env handling for client/server
  • version bumps for everything

Type of change

Please mark relevant options with an x in the brackets.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Algorithm update - updates algorithm documentation/questions/answers etc.
  • Other (please describe):

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also
list any relevant details for your test configuration

  • Integration tests
  • Unit tests
  • Manual tests
  • No tests required

Reviewer checklist

Mark everything that needs to be checked before merging the PR.

  • Check if the UI is working as expected and is satisfactory
  • Check if the code is well documented
  • Check if the behavior is what is expected
  • Check if the code is well tested
  • Check if the code is readable and well formatted
  • Additional checks (document below if any)

Screenshots (if appropriate):

Questions (if appropriate):

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 8, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 0.66% 3 / 454
🔵 Statements 0.66% 3 / 454
🔵 Functions 16.66% 3 / 18
🔵 Branches 16.66% 3 / 18
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
app/entry.server.tsx 0% 0% 0% 0% 1, 3, 5-14, 16, 18-28, 30-37, 39-40, 42-48, 50, 52, 54-58, 60-66, 68-71, 73-75, 79, 81, 83, 85, 87-92, 94-96, 107-113
app/env.server.ts 0% 0% 0% 0% 1, 3-6, 9, 15-16, 18-21, 23, 26-30, 38-43
app/root.tsx 0% 0% 0% 0% 1-7, 9-11, 13, 15-17, 19-22, 24-36, 38-40, 42
app/localization/i18n.server.ts 0% 0% 0% 0% 1-3, 5-9, 12-18, 20
app/localization/resource.ts 0% 0% 0% 0% 1-2, 4-5, 12-19
app/routes/robots[.]txt.ts 0% 0% 0% 0% 1, 3, 5-20
app/routes/sitemap-index[.]xml.ts 0% 0% 0% 0% 1, 3, 5-16, 18-23
app/routes/sitemap.$lang[.]xml.ts 0% 0% 0% 0% 1, 3, 5-6, 8, 10-13, 15-19, 21-26
app/utils/http.ts 0% 100% 100% 0% 7-11, 14-16, 18-20, 22-23
Generated in workflow #29 for commit 05907e9 by the Vitest Coverage Report Action

thomasfr
thomasfr reviewed Oct 10, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@thomasfr thomasfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If ok for you i would make some changes on the env handling after it got merged

Comment thread .vscode/settings.json
@@ -1,5 +1,4 @@
{
"editor.defaultFormatter": "biomejs.biome",
Copy link
Copy Markdown
Contributor

@thomasfr thomasfr Oct 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why removed?

Comment thread .vscode/settings.json
"[typescriptreact]": {
"biome.enabled": true,
"editor.defaultFormatter": "biomejs.biome",
"[javascript][typescript][typescriptreact][javascriptreact][json][jsonc][vue][astro][svelte][css][graphql]": {
Copy link
Copy Markdown
Contributor

@thomasfr thomasfr Oct 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get it its unfortunately needed due to VSCode or Biome bug(s) on windows, but it makes me sad ;) - i never had problems with the previous config. But yeah,... if it then works also on windows all the time its good then.

Copy link
Copy Markdown
Contributor Author

@AlemTuzlak AlemTuzlak Oct 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm this wasn't meant to be here I was testing the biome vs code extension on the repo and left it in by accident, but tbh I'm still having problems sometimes due to the extension, I think they have some bugs that makes it not work on windows in case of some crashes or something

Comment thread .vscode/settings.json
Comment on lines +37 to +39
"readme*": "AUTHORS, Authors, BACKERS*, Backers*, CHANGELOG*, CITATION*, CODEOWNERS, CODE_OF_CONDUCT*, CONTRIBUTING*, CONTRIBUTORS, COPYING*, CREDITS, Changelog*, Citation*, Code_Of_Conduct*, Codeowners, Contributing*, Contributors, Copying*, Credits, GOVERNANCE.MD, Governance.md, HISTORY.MD, History.md, LICENSE*, License*, MAINTAINERS, Maintainers, README-*, README_*, RELEASE_NOTES*, ROADMAP.MD, Readme-*, Readme_*, Release_Notes*, Roadmap.md, SECURITY.MD, SPONSORS*, Security.md, Sponsors*, authors, backers*, changelog*, citation*, code_of_conduct*, codeowners, contributing*, contributors, copying*, credits, governance.md, history.md, license*, maintainers, readme-*, readme_*, release_notes*, roadmap.md, security.md, sponsors*",
"Readme*": "AUTHORS, Authors, BACKERS*, Backers*, CHANGELOG*, CITATION*, CODEOWNERS, CODE_OF_CONDUCT*, CONTRIBUTING*, CONTRIBUTORS, COPYING*, CREDITS, Changelog*, Citation*, Code_Of_Conduct*, Codeowners, Contributing*, Contributors, Copying*, Credits, GOVERNANCE.MD, Governance.md, HISTORY.MD, History.md, LICENSE*, License*, MAINTAINERS, Maintainers, README-*, README_*, RELEASE_NOTES*, ROADMAP.MD, Readme-*, Readme_*, Release_Notes*, Roadmap.md, SECURITY.MD, SPONSORS*, Security.md, Sponsors*, authors, backers*, changelog*, citation*, code_of_conduct*, codeowners, contributing*, contributors, copying*, credits, governance.md, history.md, license*, maintainers, readme-*, readme_*, release_notes*, roadmap.md, security.md, sponsors*",
"README*": "AUTHORS, Authors, BACKERS*, Backers*, CHANGELOG*, CITATION*, CODEOWNERS, CODE_OF_CONDUCT*, CONTRIBUTING*, CONTRIBUTORS, COPYING*, CREDITS, Changelog*, Citation*, Code_Of_Conduct*, Codeowners, Contributing*, Contributors, Copying*, Credits, GOVERNANCE.MD, Governance.md, HISTORY.MD, History.md, LICENSE*, License*, MAINTAINERS, Maintainers, README-*, README_*, RELEASE_NOTES*, ROADMAP.MD, Readme-*, Readme_*, Release_Notes*, Roadmap.md, SECURITY.MD, SPONSORS*, Security.md, Sponsors*, authors, backers*, changelog*, citation*, code_of_conduct*, codeowners, contributing*, contributors, copying*, credits, governance.md, history.md, license*, maintainers, readme-*, readme_*, release_notes*, roadmap.md, security.md, sponsors*",
Copy link
Copy Markdown
Contributor

@thomasfr thomasfr Oct 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested/checked if this setting is case sensitive?

Copy link
Copy Markdown
Contributor Author

@AlemTuzlak AlemTuzlak Oct 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took it from Ant Fu repo, I'd assume he did

@AlemTuzlak AlemTuzlak merged commit 2f51331 into main Oct 10, 2024
@AlemTuzlak AlemTuzlak deleted the hono-server branch October 10, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@thomasfr thomasfr thomasfr left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AlemTuzlak @thomasfr